Fix collection cache lookup failure with enum keys #3693
Merged
+264
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
approved these changes
Sep 22, 2025
|
@mergify backport |
❌ No backport have been createdNo destination branches found |
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
Co-authored-by: Christoph Watzl <[email protected]> (cherry picked from commit 66300c1)
fredericDelaporte
added a commit
that referenced
this pull request
Sep 28, 2025
…3709) Co-authored-by: Frédéric Delaporte <[email protected]> Co-authored-by: Christoph Watzl <[email protected]> Co-authored-by: Alex Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3643
#1952 (5.3) has added support for caching fetched relations, without supporting the case where the owner id needs assembly. Prior to #1952, fetched relations were not cached. So, the provided test case was not actually working as expected, but it was still able of loading the data.
Maybe it would have to target 5.4.x.